Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Documentation] Add Routing Rules Update to Route Mgr Design #397

Merged
merged 5 commits into from
Nov 4, 2020
Merged

[Documentation] Add Routing Rules Update to Route Mgr Design #397

merged 5 commits into from
Nov 4, 2020

Conversation

cj-chung
Copy link
Contributor

@cj-chung cj-chung commented Oct 6, 2020

Add routing rules update design for use case scenario #6.

@cj-chung cj-chung self-assigned this Oct 6, 2020
@xieus xieus added the documentation Improvements or additions to documentation label Oct 6, 2020
@xieus xieus added this to the Version 1.0.2020.11.30 milestone Oct 6, 2020
@cj-chung cj-chung requested a review from xieus October 12, 2020 16:48
Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great.

Left a minor comment on workflow #4. Please take a look @cj-chung

@xieus xieus changed the title Route manager design doc for routing rules update [Documentation] Add Routing Rules Update to Route Mgr Design Nov 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #397 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #397      +/-   ##
============================================
- Coverage     36.74%   36.52%   -0.22%     
- Complexity     1150     1156       +6     
============================================
  Files           448      452       +4     
  Lines         10759    10859     +100     
  Branches       1373     1392      +19     
============================================
+ Hits           3953     3966      +13     
- Misses         6268     6350      +82     
- Partials        538      543       +5     
Impacted Files Coverage Δ Complexity Δ
...wei/alcor/portmanager/processor/NetworkConfig.java 67.44% <0.00%> (-32.56%) 15.00% <0.00%> (+1.00%) ⬇️
...lcor/portmanager/processor/DataPlaneProcessor.java 65.30% <0.00%> (-10.64%) 31.00% <0.00%> (+2.00%) ⬇️
...portmanager/request/FetchRouterSubnetsRequest.java 72.22% <0.00%> (-6.35%) 5.00% <0.00%> (+1.00%) ⬇️
...rewei/alcor/portmanager/processor/PortContext.java 62.90% <0.00%> (-4.37%) 23.00% <0.00%> (+1.00%) ⬇️
...alcor/portmanager/util/RestParameterValidator.java 41.53% <0.00%> (-3.08%) 13.00% <0.00%> (-1.00%)
...r/route/service/Impl/NeutronRouterServiceImpl.java 51.20% <0.00%> (-2.47%) 26.00% <0.00%> (+1.00%) ⬇️
...ewei/alcor/subnet/controller/SubnetController.java 65.65% <0.00%> (-0.71%) 20.00% <0.00%> (ø%)
...cor/subnet/service/implement/SubnetServiceImp.java 1.47% <0.00%> (-0.11%) 1.00% <0.00%> (ø%)
.../futurewei/alcor/route/config/ConstantsConfig.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...cor/portmanager/util/NetworkConfigurationUtil.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7886bee...e60ad73. Read the comment docs.

@xieus xieus merged commit eba3daa into futurewei-cloud:master Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants