[Data Plane Manager] UT Test Automation #394

kevin-zhonghao · 2020-09-30T22:20:47Z

Completed DPM's UT test automation

xieus · 2020-09-30T22:44:05Z

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java

+        List<NeighborInfo> neighborINFO = new ArrayList<>();
+        if (hasNeighbor) {
+            for (int i = 0; i < neighborNum; i ++) {
+                NeighborInfo neighborInfo = new NeighborInfo("10.213.43.18" + i, "ephost_0", "f37810eb-7f83-45fa-a4d4-1b31e75399d" + i, "86:ea:77:ad:52:55", "192.168.2.2", "9192a4d4-ffff-4ece-b3f0-8d36e3d88038", "a87e0f87-a2d9-44ef-9194-9a62f1785940");


Consider to keep these test parameters in a file.

xieus · 2020-10-03T11:38:18Z

...ne_manager/src/main/java/com/futurewei/alcor/dataplane/service/ovs/DataPlaneServiceImpl.java

@@ -84,13 +84,13 @@ private void buildVpcState(NetworkConfiguration networkConfig, GoalState.Builder
        }

        for (PortState portState: portStates) {


@chenpiaoping, please help review this file change. Let me know if there is any concern.

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java

xieus · 2020-10-03T13:01:55Z

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java

+        for (int j = 0; j < hostNum; j ++) {
+            for (int i = 0; i < portNum; i ++) {
+                List<PortEntity.FixedIp> fixedIps = new ArrayList<>();
+                PortEntity.FixedIp fixedIp = new PortEntity.FixedIp(DPMAutoUnitTestConstant.subnetId + i, DPMAutoUnitTestConstant.IpAddress + i);


This will make each port fall into a different subnet. Don't think it is needed. Let us have a quick sync up. @kevin-zhonghao

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java

xieus · 2020-10-05T18:17:52Z

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java

+                        null, false, null, null, 0, null, null,
+                        false, false);
+
+                List<RouteEntity> routeEntities = new ArrayList<>();


Need to use latest contract in PR #396

…o new_master

xieus · 2020-10-07T17:31:49Z

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java

+        List<NeighborInfo> neighborINFO = new ArrayList<>();
+        if (hasNeighbor) {
+            for (int i = 0; i < neighborNum; i ++) {
+                NeighborInfo neighborInfo = new NeighborInfo(DPMAutoUnitTestConstant.hostIp + i, DPMAutoUnitTestConstant.hostId, DPMAutoUnitTestConstant.portId + i, DPMAutoUnitTestConstant.portMac, DPMAutoUnitTestConstant.portIp, DPMAutoUnitTestConstant.vpcId, DPMAutoUnitTestConstant.subnetId + i);


If we use DPMAutoUnitTestConstant.portMac and DPMAutoUnitTestConstant.portIp, do that mean that we are generating multiple neighbor ports with same IP and MAC?

Yes, because we assume there is one neighbor if it has neighbor in most of cases. Do we have the case to test multiple neighbor with different IP and MAC?

xieus · 2020-10-07T17:33:19Z

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java

+        List<NeighborInfo> neighborINFO = new ArrayList<>();
+        if (hasNeighbor) {
+            for (int i = 0; i < neighborNum; i ++) {
+                NeighborInfo neighborInfo = new NeighborInfo(DPMAutoUnitTestConstant.hostIp + i, DPMAutoUnitTestConstant.hostId, DPMAutoUnitTestConstant.portId + i, DPMAutoUnitTestConstant.portMac, DPMAutoUnitTestConstant.portIp, DPMAutoUnitTestConstant.vpcId, DPMAutoUnitTestConstant.subnetId + i);


Subnet generation shouldn't reply on DPMAutoUnitTestConstant.subnetId + i.

This means that if neighborNum=N, we will have N neighbor port, each will be in a different subnet. Subnet size is always one, and basically against the following code to generate neighborTable (using NumOfIPsInSubnet1 and NumOfIPsInSubnet2).

That's right, I will fix value of the subnet id

codecov-io · 2020-10-07T19:08:45Z

Codecov Report

Merging #394 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #394      +/-   ##
============================================
+ Coverage     36.78%   36.82%   +0.03%     
- Complexity     1149     1152       +3     
============================================
  Files           447      447              
  Lines         10703    10703              
  Branches       1365     1365              
============================================
+ Hits           3937     3941       +4     
+ Misses         6232     6230       -2     
+ Partials        534      532       -2

Impacted Files	Coverage Δ	Complexity Δ
...alcor/elasticipmanager/dao/ElasticIpAllocator.java	`63.81% <0.00%> (+0.27%)`	`48.00% <0.00%> (ø%)`
...rewei/alcor/portmanager/processor/PortContext.java	`69.09% <0.00%> (+1.81%)`	`23.00% <0.00%> (+1.00%)`
...i/alcor/portmanager/processor/RouterProcessor.java	`84.37% <0.00%> (+6.25%)`	`10.00% <0.00%> (+1.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bc357...9ba72f0. Read the comment docs.

xieus

Thank you @kevin-zhonghao This PR is a very good improvement and one step towards a fully automated tests for DPM.

xieus and others added 30 commits September 30, 2019 18:24

Update design documents and table of content

d745b47

Update README.md

1fc253e

Add cloud-native key word

9b0efb6

Merge branch 'docs/design' of https://github.com/futurewei-cloud/Alio…

db0a699

…thController into docs/design

Start docs for comm and controller

424dd5b

Add design sketch

b41edb9

Design spec round 1

3e54c57

Rename fast path file and start feature comparison

d7d8ad9

Update rescue path doc [DRAFT]

4c6588e

upload rescue_path.GIF

cceaa68

update rescue path needed change table

9785656

rescue_path.GIF

3e2b63e

rescue_path.adoc

f8fc472

Design spec round 2

2480dd1

Monitoring design outline

68eda0b

Update comm docs

c1c9cc7

Update data storage design

79e91fe

Merge branch 'docs/design' of https://github.com/futurewei-cloud/Alio…

ca69892

…thController into docs/design

Update data store

8b154ab

Complete review of existing dbs

4561d1e

Update review table

ca4610e

Adjust table column width

24b4a36

Update feature comparsion table

45774da

Finalize review section in data store

18e500c

Add design diagram

cc99d14

Add a design diagram

a9c8232

Add files via upload

2823921

fix "design" session level

47b7e45

Update monitoring.adoc

8c9c004

Update monitoring.adoc

4180450

xieus reviewed Oct 2, 2020

View reviewed changes

xieus assigned kevin-zhonghao Oct 2, 2020

xieus added the unit test Unit test label Oct 2, 2020

xieus added this to the Version 1.0.2020.11.30 milestone Oct 2, 2020

update

dfb895b

xieus reviewed Oct 3, 2020

View reviewed changes

xieus changed the title ~~[Data-Plane-Manager] Auto Test Implementation~~ [Data Plane Manager] UT Test Automation Oct 3, 2020

xieus reviewed Oct 5, 2020

View reviewed changes

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java Outdated Show resolved Hide resolved

...ta_plane_manager/src/main/java/com/futurewei/alcor/dataplane/utils/DataPlaneManagerUtil.java Outdated Show resolved Hide resolved

xieus reviewed Oct 5, 2020

View reviewed changes

kevin-zhonghao added 4 commits October 5, 2020 15:37

update

cd7157e

Merge branch 'master' of https://github.com/futurewei-cloud/alcor int…

ec3de4c

…o new_master

Merge branch 'new_master' into feature/dpm_auto_test

e6f3af2

update

9fca8df

xieus reviewed Oct 7, 2020

View reviewed changes

update

d75ec07

update

9ba72f0

xieus self-requested a review October 7, 2020 21:46

xieus approved these changes Oct 7, 2020

View reviewed changes

xieus merged commit 5385893 into futurewei-cloud:master Oct 7, 2020

xieus linked an issue Oct 13, 2020 that may be closed by this pull request

Split huge GoalStateManager Test to multiple small ones #360

Closed

This was referenced Oct 13, 2020

Split huge GoalStateManager Test to multiple small ones #360

Closed

[Test] DPM UT refactor and automation framework #409

Closed

This was linked to issues Oct 16, 2020

[DPM] UT enhancement for core logic #288

Closed

[Test] DPM UT refactor and automation framework #409

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data Plane Manager] UT Test Automation #394

[Data Plane Manager] UT Test Automation #394

kevin-zhonghao commented Sep 30, 2020

xieus Sep 30, 2020

kevin-zhonghao Oct 2, 2020

xieus Oct 3, 2020

xieus Oct 3, 2020

xieus Oct 5, 2020

xieus Oct 7, 2020

kevin-zhonghao Oct 7, 2020

xieus Oct 7, 2020

kevin-zhonghao Oct 7, 2020

codecov-io commented Oct 7, 2020 •

edited

Loading

xieus left a comment

		@@ -84,13 +84,13 @@ private void buildVpcState(NetworkConfiguration networkConfig, GoalState.Builder
		}

		for (PortState portState: portStates) {

[Data Plane Manager] UT Test Automation #394

[Data Plane Manager] UT Test Automation #394

Conversation

kevin-zhonghao commented Sep 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 7, 2020 • edited Loading

Codecov Report

xieus left a comment

Choose a reason for hiding this comment

codecov-io commented Oct 7, 2020 •

edited

Loading