Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[DPM] Refactor UTs #389

Merged
merged 183 commits into from
Sep 24, 2020
Merged

Conversation

kevin-zhonghao
Copy link
Contributor

@kevin-zhonghao kevin-zhonghao commented Sep 23, 2020

This PR proposes a DPM test code refactor to extract the test payload and maintain a short test class.

Copy link
Contributor

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for helping out on DPM.

@xieus xieus added the enhancement New feature or request label Sep 24, 2020
@xieus xieus added this to the Version 0.9.2020.09.30 milestone Sep 24, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #389 into master will increase coverage by 0.86%.
The diff coverage is 58.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #389      +/-   ##
============================================
+ Coverage     34.24%   35.11%   +0.86%     
- Complexity      959      993      +34     
============================================
  Files           413      422       +9     
  Lines         10086    10415     +329     
  Branches       1228     1256      +28     
============================================
+ Hits           3454     3657     +203     
- Misses         6189     6295     +106     
- Partials        443      463      +20     
Impacted Files Coverage Δ Complexity Δ
...turewei/alcor/dataplane/config/UnitTestConfig.java 95.23% <ø> (ø) 1.00 <0.00> (?)
...urewei/alcor/route/exception/CanNotFindSubnet.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...futurewei/alcor/route/exception/CanNotFindVpc.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...route/exception/OwnMultipleVpcRouterException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ute/service/Impl/VpcRouterToSubnetServiceImpl.java 20.00% <20.00%> (ø) 1.00 <1.00> (?)
.../route/service/Impl/VpcRouterToVpcServiceImpl.java 28.57% <28.57%> (ø) 1.00 <1.00> (?)
...r/route/service/Impl/NeutronRouterServiceImpl.java 59.71% <33.33%> (-0.44%) 25.00 <0.00> (ø)
.../futurewei/alcor/route/utils/RouteManagerUtil.java 55.55% <38.88%> (-6.67%) 9.00 <3.00> (+3.00) ⬇️
...lcor/route/controller/NeutronRouterController.java 60.15% <50.00%> (+0.31%) 12.00 <0.00> (ø)
...rewei/alcor/route/controller/RouterController.java 61.86% <61.20%> (-38.14%) 11.00 <10.00> (+10.00) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a8ec7...6ea0fe0. Read the comment docs.

@xieus xieus changed the title [Data-Plane-Manager] Refactor UTs [DPM] Refactor UTs Sep 24, 2020
@xieus xieus merged commit 78d66d6 into futurewei-cloud:master Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] DPM UT refactor and automation framework [DPM] UT enhancement for core logic
4 participants