[DPM/ACA Schema] Update Routing_rules and Add RoutingRuleExtraInfo Message #381
Conversation
er1cthe0ne
requested review from
xieus,
kevin-zhonghao,
haboy52581 and
cj-chung
er1cthe0ne
changed the title
| string destination = 4; | ||
| string nextHop = 5; | ||
| string destination = 4; // destination IP, could be 154.12.42.24/32 (host address) or 0.0.0.0/0 (network address) | ||
| string next_hop_ip = 5; |
There was a problem hiding this comment.
Do we expect this has to be IP, or could be others like a label?
There was a problem hiding this comment.
this is expected to be IP only, confirmed with James this morning.
There was a problem hiding this comment.
Yes. "nexthop" should be an IP address of a gateway, but we can use "nexthop_type" to indicate what type of the nexthop or gateway, such as "local", "vpc", "internet", "ngw", etc...
There was a problem hiding this comment.
should it be nexthop_type or destination_type existed in RoutingRuleExtraInfo?
I think destination_type is more appropriate since it is more important about the destination.
There was a problem hiding this comment.
Okay thanks for the confirmation.
Keep in mind that this change will ask an upstream microservices (either RM or others) to read the user-input rules (which uses next_hop) and convert the customer object into an infra object (with next_hop_ip).
| string destination = 4; | ||
| string nextHop = 5; | ||
| string destination = 4; // destination IP, could be 154.12.42.24/32 (host address) or 0.0.0.0/0 (network address) | ||
| string next_hop_ip = 5; |
There was a problem hiding this comment.
Okay thanks for the confirmation.
Keep in mind that this change will ask an upstream microservices (either RM or others) to read the user-input rules (which uses next_hop) and convert the customer object into an infra object (with next_hop_ip).
xieus
changed the title
xieus
changed the title
This is a proposal of DPM/ACA contract change to support routing rules in Alcor Control Agent. In a high-level, routing rules are use for:
Notable changes includes