This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
[DPM] Fix Hashcode Bug Causing 10s Latency for 10K Neighbors #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haboy52581 Please update PR title and description. You could refer to #376 in the PR but don't expect people know what #376 is about. Explicit is the key. |
xieus
changed the title
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the issue raised by Issue #376. The current hashcode generation method in NeighborInfo Class returns constant value, which is particularly unsuitable for large neighbor scenario. As the performance test by #376, 10K neighbor caused 10+s latency as the same hashCode value forced each entry to be added to the HashSet to compare all the existing entries due to hash conflicts.
This PR proposes the following change: