Node Manager - Meta data management #185

kimeunju108 · 2020-05-07T09:20:51Z

Node Manager (Part I) manages host (node) meta data information such as node id, ip address, veth, MAC, etc. Here is the brief description of node manager:

Node meta data management: create, get, list, update, delete, bulk add
Interact with ignite and build/manage host table.
Read a configuration file (e.g. machine.json)
Exception handling: Parameter, null, data validation, etc
Deployment: Update Application.properties and pom file
Test: Junit test cases to test REST APIs

This reverts commit 336e499.

… into eunju/macmanager

…r doc

… into eunju/macmanager

…implemention layer

… into eunju/macmanager

…ctivate/deactivate APIs

Eunju/macmanager - Added MAC range APIs and MAC allocation activate/deactivate APIs

…ate API

… into eunju/macmanager

… neutron sections on the document

… comparison with neutron

…between document and implementation

… file, (2) removed memory repository part

xieus

Please take a look at some early feedback.

...src/com/futurewei/alcor/controller/resourcemgr/physical/nodemgmt/DataCenterConfigLoader.java

.../node_manager/src/main/java/com/futurewei/alcor/nodemanager/utils/RestPreconditionsUtil.java

services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/utils/NodeUtil.java

services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/service/NodeService.java

… machine.json

…. machine.json

machine.json

…ed UT

xieus

Saw some changes to MacManager so left some comments first.

lib/src/main/java/com/futurewei/alcor/common/repo/ICacheRepository.java

services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/dao/MacPoolRepository.java

services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/dao/MacRangeRepository.java

services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/entity/MacAddress.java

services/mac_manager/src/main/java/com/futurewei/alcor/macmanager/entity/MacRange.java

...c_manager/src/main/java/com/futurewei/alcor/macmanager/service/implement/MacServiceImpl.java

...ode_manager/src/test/java/com/futurewei/alcor/nodemanager/controller/NodeControllerTest.java

xieus

A few more comments on the new change of Node Manager.

...ode_manager/src/test/java/com/futurewei/alcor/nodemanager/controller/NodeControllerTest.java

services/node_manager/src/main/resources/application.properties

services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/dao/NodeRepository.java

...anager/src/main/java/com/futurewei/alcor/nodemanager/service/implement/NodeConfigLoader.java

services/node_manager/src/main/java/com/futurewei/alcor/nodemanager/service/NodeService.java

xieus · 2020-05-14T16:05:45Z

Close duplicated PR.

kimeunju108 and others added 30 commits April 6, 2020 03:14

[Microservices] Mac address manager

d933b0d

[Microservices] Mac address manager - APIs create, get, delete

f6316b4

[Microservices] Mac manager - update pom file and lib files

e4b5604

[Microservies] Macmanager document update

336e499

Revert "[Microservies] Macmanager document update"

969841b

This reverts commit 336e499.

update macmanager design such as api and data structure

55d9c59

Add design sketch for new requirements

677cf6e

Update mac manager design doc

449d6e6

[Microservices] Mac manager - updated unit test cases

5886a77

[Microservices] Mac manager - updated unit test cases

feb5a20

Merge branch 'eunju/macmanager' of https://github.com/kimeunju108/alcor…

c5dd021

… into eunju/macmanager

Merge from featurewei/alcor master and resolve conflicts on macmanage…

391ba83

…r doc

[Microservices] Mac manager - updated pictures and unit test cases

62957d3

[Microservices] Mac manager - added mac range and mac address pool

935e57f

Merge branch 'eunju/macmanager' of https://github.com/kimeunju108/alcor…

4d1f37a

… into eunju/macmanager

Merge branch 'master' into eunju/macmanager

ca953ae

[Microservices] Mac manager - added macmanager service interface and …

00e766c

…implemention layer

Merge branch 'eunju/macmanager' of https://github.com/kimeunju108/alcor…

3f44896

… into eunju/macmanager

[Microservices] Mac manager - add MAC range APIs and MAC allocation a…

33466fb

…ctivate/deactivate APIs

Merge pull request #1 from kimeunju108/eunju/macmanager

a86d141

Eunju/macmanager - Added MAC range APIs and MAC allocation activate/deactivate APIs

[Microservices] Macmanager - combined activate/deactivate APIs to upd…

6f05522

…ate API

Fix broken maven CI workflow

0d23506

[Microservices] MAC manager - update a pom file

7ca5df6

Merge branch 'eunju/macmanager' of https://github.com/kimeunju108/alcor…

2137d4c

… into eunju/macmanager

[Microservices] MAC manager - added concurrent handling and comparing…

42e4ca5

… neutron sections on the document

[Microservices] MAC manager - added two sections: concurrent handling…

e30c48c

… comparison with neutron

[Microservices] MAC manager - updated delete API response

0b852b2

[Microservices] MAC manager - updated activate/deactivate APIs response

3c223d9

[Microservices] MAC manager - updated activate/deactivate APIs response

6ac310e

[Microservices] MAC manager - tested APIs and matched output formaat …

3d3a0f4

…between document and implementation

kimeunju108 added 7 commits May 6, 2020 23:41

[Microservices] Node manager - removed

ce83658

[Microservices] changed pom file

53b4f7a

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

d6cd345

Merge branch 'eunju/nodemanager'

e7cb5d5

[Microservices] Node manager - (1) added API that read machine config…

18287ea

… file, (2) removed memory repository part

[Micro-service] Node manager

ae74048

[Micro services] Node manager - implemented meta data management

62c5e33

kimeunju108 requested review from chenqianfzh, haboy52581, kevin-zhonghao and xieus and removed request for chenqianfzh May 7, 2020 09:21

xieus suggested changes May 7, 2020

View reviewed changes

kimeunju108 added 4 commits May 7, 2020 21:50

[Micro services] Node manager - added an APIto upload node file (e.g.…

29706bb

… machine.json

[Micro services] Node manager - added an API to upload node file (e.g…

0450f6a

…. machine.json

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

f8c8f57

Merge branch 'eunju/nodemanager'

2cb920f

xieus reviewed May 8, 2020

View reviewed changes

machine.json Show resolved Hide resolved

kimeunju108 added 5 commits May 8, 2020 00:50

[Micro service] MACmanager - added allocation tracking function, test…

43a8e7d

…ed UT

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

9e2b3c6

Merge branch 'eunju/macmanager'

3510072

Merge branch 'master' of https://github.com/kimeunju108/alcor

3fdf37f

test

dfc0611

xieus suggested changes May 9, 2020

View reviewed changes

xieus reviewed May 9, 2020

View reviewed changes

...ode_manager/src/test/java/com/futurewei/alcor/nodemanager/controller/NodeControllerTest.java Show resolved Hide resolved

xieus suggested changes May 9, 2020

View reviewed changes

xieus mentioned this pull request May 9, 2020

[Microservice] Port Manager #180

Merged

kimeunju108 mentioned this pull request May 10, 2020

[Microservice] Node Manager - Metadata Management #189

Merged

xieus closed this May 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node Manager - Meta data management #185

Node Manager - Meta data management #185

kimeunju108 commented May 7, 2020

xieus left a comment

xieus left a comment

xieus left a comment

xieus commented May 14, 2020

Node Manager - Meta data management #185

Node Manager - Meta data management #185

Conversation

kimeunju108 commented May 7, 2020

xieus left a comment

Choose a reason for hiding this comment

xieus left a comment

Choose a reason for hiding this comment

xieus left a comment

Choose a reason for hiding this comment

xieus commented May 14, 2020