-
Notifications
You must be signed in to change notification settings - Fork 29
Add grpc thread for pulsar subscribe info #274
base: master
Are you sure you want to change the base?
Conversation
add mq test for both multicast and unicast
Consumer now can update GoalStateV2 messages
fix pulsar producer orderingKey bugs
add unicastResubscribe function.
add subscribe topic info gtest.
Hi @lly00 , thank you for the PR. I looked at the files, and one thing I noticed is that, some of the newly added files, for example,
are very similar, if not identical to the existing files. It looks like that you are trying to add a new gRPC service to ACA. If so, you should consider utilizing the existing gRPC server/client, rather than creating new ones that serves the same purpose. With your current code, I believe it will create two gRPC servers and clients, which is not what we want. I believe some modifications in Thank you. |
Got, I'll try it. |
add different log info
@lly00 I noticed that you pushed some updates recently, was the previous concerns addressed? Also, could you please resolve the conflicts so that the checks can be run? Thank you. |
We added some updates to differentiate messages from gRPC and pulsar for easier debugging. I might also need to make some other updates for testing. After this, I will resolve the conflict for review. |
This PR contains:
A sample output: