Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Zeta] fix concurrency errors and change the oam_cache data structure (#188) #192

Merged
merged 1 commit into from
Jan 15, 2021
Merged

[Zeta] fix concurrency errors and change the oam_cache data structure (#188) #192

merged 1 commit into from
Jan 15, 2021

Conversation

zhangml
Copy link
Contributor

@zhangml zhangml commented Jan 14, 2021

#188 Fix concurrency errors and change the cache data structure to CTSL::HashMap. @er1cthe0ne

  1. The lock is still retained (an error will occur after the lock is removed), but it is moved inside the method.
  2. In my environment, there will be no concurrent quit errors.

@zhangml zhangml force-pushed the fix_concurrent_error branch from 83b4d7a to d65239d Compare January 14, 2021 13:04
@er1cthe0ne er1cthe0ne self-requested a review January 15, 2021 02:36
@er1cthe0ne er1cthe0ne added the Zeta Integration with Zeta label Jan 15, 2021
@er1cthe0ne er1cthe0ne linked an issue Jan 15, 2021 that may be closed by this pull request
DISABLED_zeta_scale_PARENT quits abruptly. #188
Closed
er1cthe0ne
er1cthe0ne approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@er1cthe0ne er1cthe0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this.

@er1cthe0ne er1cthe0ne changed the title fix concurrency errors and change the oanm_cache data structure [Zeta] fix concurrency errors and change the oanm_cache data structure (#188) Jan 15, 2021
@er1cthe0ne er1cthe0ne changed the title [Zeta] fix concurrency errors and change the oanm_cache data structure (#188) [Zeta] fix concurrency errors and change the oam_cache data structure (#188) Jan 15, 2021
@er1cthe0ne er1cthe0ne merged commit f448806 into futurewei-cloud:master Jan 15, 2021
@zhangml zhangml deleted the fix_concurrent_error branch January 27, 2021 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@er1cthe0ne er1cthe0ne er1cthe0ne approved these changes

Assignees

@zhangml zhangml

Labels
Zeta Integration with Zeta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DISABLED_zeta_scale_PARENT quits abruptly.
2 participants
@zhangml @er1cthe0ne