-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
@zhangml Hi, FYI, I'm seeing this error when running scale test, do you think it is fixed your latest code? Thanks.
|
The bug did not appear when executing ./build/tests/aca_tests. But I'm not sure whether it is the same in a scale testing environment? Please tell me how to perform this test? |
Sure, if you have the test environment set up, the following is how to reproduce that error:
Thanks. |
@zhangml - I took a more detail look at this PR, we are moving in the right direction, we should do the following as the next steps:
|
a968092
to
787fecf
Compare
@er1cthe0ne I have run all the tests and the test results are as follows:
But there is a failed test DISABLED_pulsar_consumer_test. The results are as follows:
|
thanks for sharing the test result, it looks good. The DISABLED_pulsar_consumer_test failure is expected because it requires pulsar setup which you don't have. I have merged in my PR as discussed, the next step is to rebase your branch with offical master and then we can plan to merge this in. |
Hi @zhangml Thank you very much for sharing the your test results. Can you please try to run This requires the When I run the above test, I got this weird outpout:
After the last line, no more outputs were generated for this test, it just ended abruptly. I wonder if it's because of the environment I have, can you please run the test on your side and share the results? Thank you. |
@zzxgzgz Are you adding just 3 ports? the "ip addr add 123.0.0.x/16 dev tapxxx" command tooks a little too long for just ovsdb update in user space (25ms) |
I'm trying to add 5 ports on this aca node, and as I mentioned above the test quits abruptly without showing if the test passed or failed, it just ended there. |
@zzxgzgz - to generate aca_data.json, does it require a pseudo controller setup or can we share a sample/static aca_data.json here?
@liangbin-pub these command is for aca demo mode only to setup internal OVS port on br-int when there is no VM/Container setup. It will not be executed in non-demo mode in openstack environment. |
This is a sample of
To use it with your setup, you need to:
|
Hi, @zzxgzgz I ran the test using the latest version of the code(https://github.com/zhangml/alcor-control-agent/tree/integration). This is the result of my test:
|
I ran it 10 times and the result was the same. But unlike Rio, the aca_data.json I used is copied directly from the comments, and the code I used for testing is my latest PR. |
Interesting, I also used the aca_data.json copied from the comments and also use the latest code in this PR. Next step, please go ahead to rebased with the official master, there is more comments in the add_flow code which may help. And then we will run the test again on both sides. |
Thanks you for testing, I think there are something not right in my environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now. Let's go ahead to merge this in now and continue with integration testing with Zeta.
This change include:
ovs-ofctl add-flow br-tun table=22,priority=50,dl_vlan=100,actions="strip_vlan,load:0x1->NXM_NX_TUN_ID[],group:100"