Skip to content

Commit

Permalink
resolved() for ClusterFuture:s would produce Error: 'inherits(future,…
Browse files Browse the repository at this point in the history
… "Future")' is not TRUE [#723]
  • Loading branch information
HenrikBengtsson committed May 28, 2024
1 parent eaa6d48 commit 99f8dda
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: future
Version: 1.33.2-9000
Version: 1.33.2-9001
Title: Unified Parallel and Distributed Processing in R for Everyone
Imports:
digest,
Expand Down
7 changes: 6 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Version (development version)

* ...
## Bug Fixes

* `resolved()` for `ClusterFuture`:s would produce `Error:
'inherits(future, "Future")' is not TRUE` instead of an intended,
informative error message that the connection to the parallel
worker is broken.


# Version 1.33.2 [2024-03-23]
Expand Down
4 changes: 2 additions & 2 deletions R/ClusterFuture-class.R
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,8 @@ resolved.ClusterFuture <- function(x, run = TRUE, timeout = NULL, ...) {
isValid <- isConnectionValid(con)
if (!isValid) {
ex <- simpleError("Connection to the worker is corrupt")
msg <- post_mortem_cluster_failure(ex, when = "checking resolved from", node = node, future = future)
stop(FutureError(msg, future = future))
msg <- post_mortem_cluster_failure(ex, when = "checking resolved from", node = node, future = x)
stop(FutureError(msg, future = x))
}

if (is.null(timeout)) {
Expand Down

0 comments on commit 99f8dda

Please sign in to comment.