Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hilt support for Arkitekt core #147

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Hilt support for Arkitekt core #147

merged 2 commits into from
Feb 22, 2021

Conversation

davidkocnar
Copy link
Member

No description provided.

@davidkocnar
Move whole Dagger 2 related ViewModel implementation to :dagger modul…
b19ae78 
…e, so that :core module is prepared for Hilt
@davidkocnar davidkocnar linked an issue Feb 17, 2021 that may be closed by this pull request
Create BaseActivity & BaseFragment with Binding and ViewModel compatible with Hilt #145
Open
@futured-bot
Copy link

futured-bot commented Feb 17, 2021 •
edited
Loading

2 Warnings
⚠️ This pull request is too big.
⚠️ core-test/src/main/java/app/futured/arkitekt/core/viewmodel/BaseViewModelExtensionsMock.kt#L69 - Function names should be at most 35 characters long.

Generated by 🚫 Danger

@skywall skywall changed the base branch from 4.x to 5.x February 22, 2021 13:18
skywall
skywall approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@skywall skywall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@skywall skywall merged commit 49868d1 into 5.x Feb 22, 2021
@skywall skywall deleted the feature/arkitekt-hilt-support branch February 22, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skywall skywall skywall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create BaseActivity & BaseFragment with Binding and ViewModel compatible with Hilt
3 participants
@davidkocnar @futured-bot @skywall