-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ALL/DISTINCT/ORDER BY in aggregate functions #12
Conversation
今回の修正で以下の警告が発生するようになっているようです。
今後使用する可能性があるforce_multi_lineメソッドを今消す必要はないと思うので、警告を回避するため以下のアトリビュートを付与してください。 #[allow(dead_code)]
pub(crate) fn force_multi_line(&self) -> bool {
self.force_multi_line
} |
|
追加の修正で以下警告が出るようになっていたので、そちらの対応(use itertools::Itertools の削除)もお願いします 🙇
|
失礼しました:bow: |
LGTM |
ALL/DISTINCT/ORDER BY in aggregate functions are supported.
Grammar is based on here.
An example format is as follows
ALL
DISTINCT
ORDER_BY
Close #10
Close #11