Change server context shape, make SSRBodyTemplate optional #294

rtsao · 2018-09-17T20:03:34Z

This PR further decouples fusion-core from fusion-cli.

Changes

Remove default SSRBodyTemplate, make it optional. For simulation tests, assertions should just use ctx.rendered, rather than assuming how ctx.body gets constructed.
Change default SSRDecider to check path prefix against ctx.assetBase rather than check extensions.
Change server context shape:

prefix
cdnUrl
nonce
useragent
element
- rootDir
- env
- assetPath
- preloadChunks
- webpackPublicPath
- syncChunks
- chunkUrlMap
+ assets
+ assetBase
+ criticalAssets
+ chunkAssetIndex

revskill10 · 2018-09-18T02:42:27Z

src/plugins/ssr.js

-      // If the request has one of these extensions, we assume it's not something that requires server-side rendering of virtual dom
-      // TODO(#46): this check should probably look at the asset manifest to ensure asset 404s are handled correctly
-      if (ctx.path.match(/\.(js|gif|jpg|png|pdf|json)$/)) return false;
+      if (ctx.path.startsWith(ctx.assetBase)) return false;
      // The Accept header is a good proxy for whether SSR should happen


We should use req.accepts(['html', 'json']) === 'html' instead ?

Should we also provide whitelist extensions as default for user to override/extend ?

What i want is to make sure default FusionJS website could be scraped and indexed by Bots.

rtsao · 2018-09-20T18:14:47Z

Closing in favor of #299

Change server context shape, make SSRBodyTemplate optional

6c12ca5

rtsao added the breaking label Sep 17, 2018

revskill10 reviewed Sep 18, 2018

View reviewed changes

rtsao closed this Sep 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change server context shape, make SSRBodyTemplate optional #294

Change server context shape, make SSRBodyTemplate optional #294

rtsao commented Sep 17, 2018 •

edited

Loading

revskill10 Sep 18, 2018

revskill10 Sep 18, 2018

revskill10 Sep 19, 2018 •

edited

Loading

rtsao commented Sep 20, 2018

Change server context shape, make SSRBodyTemplate optional #294

Change server context shape, make SSRBodyTemplate optional #294

Conversation

rtsao commented Sep 17, 2018 • edited Loading

revskill10 Sep 18, 2018

Choose a reason for hiding this comment

revskill10 Sep 18, 2018

Choose a reason for hiding this comment

revskill10 Sep 19, 2018 • edited Loading

Choose a reason for hiding this comment

rtsao commented Sep 20, 2018

rtsao commented Sep 17, 2018 •

edited

Loading

revskill10 Sep 19, 2018 •

edited

Loading