Limit search results and add metrics #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 8 +1
Lines 187 207 +20
Branches 14 15 +1
=====================================
+ Hits 187 207 +20 |
|
Reviewed 5 of 7 files at r1, 3 of 3 files at r2. setup.py, line 26 at r2 (raw file):
Don't you also need to update Comments from Reviewable |
|
Reviewed 1 of 7 files at r1, 1 of 1 files at r3. setup.py, line 26 at r2 (raw file): Previously, jonathanj (Jonathan Jacobs) wrote…
Done. Comments from Reviewable |
|
Reviewed 1 of 1 files at r3, 1 of 1 files at r4. Comments from Reviewable |
complete! all files reviewed, all discussions resolved
|
bors r+ Comments from Reviewable |
bors-fusion bot
added a commit
that referenced
this pull request
Jul 3, 2018
206: Limit search results and add metrics r=jonathanj a=mithrandi Closes #10. Co-authored-by: Tristan Seligmann <[email protected]>
|
bors r+ |
bors-fusion bot
added a commit
that referenced
this pull request
Jul 3, 2018
206: Limit search results and add metrics r=mithrandi a=mithrandi Closes #10. Co-authored-by: Tristan Seligmann <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10.
This change is