Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proc_macro_hack dependency #15

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Remove proc_macro_hack dependency #15

merged 2 commits into from
Dec 13, 2021

Conversation

bpandreotti
Copy link
Contributor

Since Rust 1.45, procedural macros in expression position are stable, so proc_macro_hack is no longer needed.

@de-vri-es
Copy link
Collaborator

Thanks for the PR. I totally agree we should get rid of proc_macro_hack now.

One thing though: I think the documentation should be moved to the real macro now instead of the pub use.

@bpandreotti
Copy link
Contributor Author

Yeah, that makes sense.

@de-vri-es
Copy link
Collaborator

Looks good. Thanks!

@de-vri-es de-vri-es merged commit 4d8786e into fusion-engineering:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpandreotti @de-vri-es