Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor exporting to h5m #264

Merged
merged 8 commits into from
Sep 24, 2022
Merged

refactor exporting to h5m #264

merged 8 commits into from
Sep 24, 2022

Conversation

shimwell
Copy link
Member

refactor exporting to h5m to work with updated downstream api changes

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #264 (f6704d6) into main (3c89fb9) will increase coverage by 0.22%.
The diff coverage is 97.29%.

❗ Current head f6704d6 differs from pull request most recent head 7765239. Consider uploading reports for the commit 7765239 to get more accurate results

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   96.25%   96.48%   +0.22%     
==========================================
  Files          82       82              
  Lines        5507     5523      +16     
==========================================
+ Hits         5301     5329      +28     
+ Misses        206      194      -12     
Impacted Files Coverage Δ
paramak/reactor.py 79.91% <ø> (-0.09%) ⬇️
paramak/utils.py 94.87% <97.29%> (+3.07%) ⬆️
paramak/shape.py 97.41% <0.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

paramak/utils.py Outdated Show resolved Hide resolved
@shimwell
Copy link
Member Author

just the codecov upload part of the circle ci tests failed.

@shimwell shimwell merged commit 09756cf into main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant