Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

central folder for tests #248

Merged
merged 6 commits into from
Jun 29, 2022
Merged

central folder for tests #248

merged 6 commits into from
Jun 29, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

Just restructuring the tests and calls to tests so that everything is in one tests folder

Types of changes

What types of changes does your code introduce to the Paramak?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the title trim spaces central folder for tests Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #248 (c6cebd4) into develop (297a76b) will increase coverage by 1.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #248      +/-   ##
===========================================
+ Coverage    94.77%   96.71%   +1.94%     
===========================================
  Files           82       82              
  Lines         5507     5969     +462     
===========================================
+ Hits          5219     5773     +554     
+ Misses         288      196      -92     
Impacted Files Coverage Δ
paramak/parametric_components/cutting_wedge.py 100.00% <0.00%> (ø)
paramak/parametric_components/divertor_ITER.py 100.00% <0.00%> (ø)
paramak/parametric_components/tokamak_plasma.py 100.00% <0.00%> (ø)
paramak/parametric_components/rotated_trapezoid.py 100.00% <0.00%> (ø)
...aramak/parametric_components/poloidal_segmenter.py 100.00% <0.00%> (ø)
...ak/parametric_components/poloidal_field_coil_fp.py 100.00% <0.00%> (ø)
...k/parametric_components/poloidal_field_coil_set.py 100.00% <0.00%> (ø)
.../parametric_components/blanket_cutter_parallels.py 100.00% <0.00%> (ø)
...arametric_components/rotated_isosceles_triangle.py 100.00% <0.00%> (ø)
...arametric_components/tokamak_plasma_from_points.py 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297a76b...c6cebd4. Read the comment docs.

@shimwell
Copy link
Member Author

CI errors are

Excessive memory consumption on readthedocs

Encountered problems while solving: package python-3.9.0-hcff3b4d_1 requires openssl >=1.1.1h,<1.1.2a, but none of the providers can be installed

I think these are unrelated to this PR

@shimwell shimwell merged commit 12e0366 into develop Jun 29, 2022
@shimwell shimwell deleted the one_location_for_tests branch June 29, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant