Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to main merge #241

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Develop to main merge #241

merged 4 commits into from
Apr 21, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

Just bringing in a quick fix for the vacuum material bug

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #241 (4764c20) into main (33250ac) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   95.29%   95.29%   -0.01%     
==========================================
  Files          82       82              
  Lines        5508     5507       -1     
==========================================
- Hits         5249     5248       -1     
  Misses        259      259              
Impacted Files Coverage Δ
...amak/parametric_components/dished_vacuum_vessel.py 82.05% <ø> (ø)
...mak/parametric_reactors/flf_system_code_reactor.py 100.00% <ø> (ø)
...ametric_reactors/negative_triangularity_reactor.py 89.84% <ø> (ø)
paramak/reactor.py 72.94% <ø> (-0.11%) ⬇️
...k/parametric_components/constant_thickness_dome.py 92.78% <100.00%> (ø)
paramak/shape.py 95.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33250ac...4764c20. Read the comment docs.

@shimwell shimwell merged commit 96a8c37 into main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant