Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #24

Merged
merged 34 commits into from
Jul 15, 2021
Merged

Develop #24

merged 34 commits into from
Jul 15, 2021

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jul 14, 2021

Proposed changes

Adds a new vacuum vessel component by @Blitan to the main distribution and fixes a few typos in the docs.

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Blitan and others added 30 commits July 12, 2021 11:34
Removed unnecessary code

Co-authored-by: Jonathan Shimwell <[email protected]>
…gy/paramak into adding-capsule-vacuum-vessel
Removed unnecessary code

Co-authored-by: Jonathan Shimwell <[email protected]>
…gy/paramak into adding-capsule-vacuum-vessel
…gy/paramak into adding-capsule-vacuum-vessel
…gy/paramak into adding-capsule-vacuum-vessel
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ba3d58e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   97.48%           
=======================================
  Files           ?       73           
  Lines           ?     4805           
  Branches        ?        0           
=======================================
  Hits            ?     4684           
  Misses          ?      121           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3d58e...443a636. Read the comment docs.

@shimwell
Copy link
Member Author

Will leave this PR open for a day in case anyone has comments

@shimwell shimwell merged commit cfbfe48 into main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants