Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added graveyard tag tests #236

Merged
merged 19 commits into from
Apr 11, 2022
Merged

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Apr 6, 2022

Proposed changes

Work in progress. This PR will add the option of exporting the DAGMC file with a graveyard. This is useful for codes that don't yet support implicit graveyards or allow graveyards to be made from CSG cells.

I've added unit tests but need to add the functionality next

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Member Author

The Unexpected argument '(typing.Any,)' error already has an open PR on Cadquery so looks like this will be fixed soon.

I've tested this with the two neutronics examples on fusion-energy org

@shimwell shimwell merged commit 8e03e9d into develop Apr 11, 2022
@shimwell shimwell deleted the adding_optional_graveyard_to_dagmc_export branch April 11, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant