Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update #206

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Docs update #206

merged 4 commits into from
Mar 9, 2022

Conversation

py1sl
Copy link
Contributor

@py1sl py1sl commented Mar 9, 2022

Proposed changes

updated documentation links to fusion-energy rather than UKAEA versions so that any changes made are reflected in the documentation links. This is including example notebooks, CI links etc, but not including links to documents completed under UKAEA e.g. pullrequest report.

There is still one broken link on the index page to the arc reactor paper, but I cannot find the correct link. @shimwell if you can supply the correct link or edit directly

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@shimwell shimwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can fix the link to the ARC paper
https://iopscience.iop.org/article/10.1088/1741-4326/ac5450

@shimwell
Copy link
Member

shimwell commented Mar 9, 2022

failing tests are unrelated.

@shimwell shimwell merged commit 6b2104e into fusion-energy:develop Mar 9, 2022
@py1sl py1sl deleted the docs_update branch March 9, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants