Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #173 from fusion-energy/minor_fixes #174

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jan 28, 2022

Minor fixes

Proposed changes

Fixed ci tests and removed unused imports

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #174 (be93702) into main (c27ccde) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   97.67%   97.67%   -0.01%     
==========================================
  Files          77       77              
  Lines        4824     4816       -8     
==========================================
- Hits         4712     4704       -8     
  Misses        112      112              
Impacted Files Coverage Δ
paramak/parametric_components/tf_coil_casing.py 100.00% <ø> (ø)
...k/parametric_components/vacuum_vessel_inner_leg.py 89.06% <ø> (-0.17%) ⬇️
paramak/shape.py 96.70% <ø> (-0.02%) ⬇️
...ric_components/blanket_constant_thickness_arc_v.py 100.00% <100.00%> (ø)
paramak/parametric_components/blanket_fp.py 100.00% <100.00%> (ø)
...ak/parametric_components/center_column_circular.py 100.00% <100.00%> (ø)
paramak/parametric_components/extrude_rectangle.py 100.00% <100.00%> (ø)
...ramak/parametric_components/poloidal_field_coil.py 100.00% <100.00%> (ø)
...amak/parametric_components/port_cutters_rotated.py 100.00% <100.00%> (ø)
paramak/parametric_components/shell_fs.py 96.15% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27ccde...be93702. Read the comment docs.

@shimwell shimwell merged commit d30900d into main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant