Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extrude hollow reactangle #146

Merged
merged 7 commits into from
Dec 14, 2021
Merged

Conversation

shimwell
Copy link
Member

Proposed changes

Adds a new parametric shape that is an extruded hollow rectangle

I still need to add tests and documentation to finish this PR

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Member Author

shimwell commented Dec 13, 2021

Added docs, images and tests

@shimwell
Copy link
Member Author

Extrude_hollow_reactange drawio(3)

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #146 (6133663) into develop (372ff40) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 6133663 differs from pull request most recent head 5344322. Consider uploading reports for the commit 5344322 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #146      +/-   ##
===========================================
+ Coverage    97.73%   97.75%   +0.01%     
===========================================
  Files           76       77       +1     
  Lines         4688     4720      +32     
===========================================
+ Hits          4582     4614      +32     
  Misses         106      106              
Impacted Files Coverage Δ
.../parametric_components/blanket_cutter_parallels.py 100.00% <ø> (ø)
...amak/parametric_components/blanket_cutters_star.py 100.00% <ø> (ø)
...ak/parametric_components/center_column_cylinder.py 100.00% <ø> (ø)
paramak/parametric_components/extrude_rectangle.py 100.00% <ø> (ø)
paramak/reactor.py 88.10% <ø> (ø)
paramak/__init__.py 100.00% <100.00%> (ø)
.../parametric_components/extrude_hollow_rectangle.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372ff40...5344322. Read the comment docs.

@shimwell shimwell merged commit d7a3257 into develop Dec 14, 2021
@shimwell shimwell deleted the adding_extrude_hollow_reactangle branch December 14, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant