Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #108

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Develop #108

merged 3 commits into from
Sep 28, 2021

Conversation

shimwell
Copy link
Member

Proposed changes

Adds default stp filenames for reactor.export_stp(). If filename is left as None then the shape.name will be used as the stem of the stp file. This makes it easier to export the stp file for a reactor when users don't nessecarily know the number or order of components in the reactor

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Member Author

the functionality changes are quite minor, just there are a few pep8 changes as well

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.78%. Comparing base (02c89e7) to head (1c72979).
Report is 780 commits behind head on main.

Files Patch % Lines
paramak/reactor.py 56.52% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   96.84%   96.78%   -0.07%     
==========================================
  Files          76       76              
  Lines        4724     4728       +4     
==========================================
+ Hits         4575     4576       +1     
- Misses        149      152       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shimwell shimwell merged commit 5348fbd into main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant