-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor and removal of redundant neutronics/h5m related code #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eyard_sector_wedge export graveyard now defaults to false
…paramak into stp_stl_filename_refactor
Adding brep export to shape
Stp stl filename refactor
added Reactor.export_brep
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 98.22% 96.84% -1.38%
==========================================
Files 76 76
Lines 4895 4724 -171
==========================================
- Hits 4808 4575 -233
- Misses 87 149 +62 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds
export_brep()
toShape
andReactor
class and removes redundant attributes (stp_filename
,stl_filename
,material_tags
)The paramak use to contain the ability to export h5m files and perform neutronics simulations as it was restritect to a single repository. The ability to export h5m files is now rewritten and in the
cad_to_h5m
package and the ability to run neutronics simulations is now in theopenmc-dagmc-wrapper
package. This allows for a decent amount of code removal as the paramak can now focus on creating geometry solely.Types of changes
Checklist