Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring AnsiConsoleSupport #266

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Refactoring AnsiConsoleSupport #266

merged 10 commits into from
Oct 2, 2023

Conversation

Glavo
Copy link
Contributor

@Glavo Glavo commented Sep 29, 2023

  • Move the classes related to AnsiConsoleSupport to org.fusesource.jansi.internal;
  • Using static final variables to cache CLibrary and Kernel32 in AnsiConsoleSupportHolder;
    The purpose is to avoid duplicate creation of CLibrary and Kernel32, and make it easier to be inlined by the JIT compiler;
  • Delete JANSI_PROVIDERS_DEFAULT, because I think there should be a more flexible selection strategy by default rather than just relying on a list;
  • Make ffm not selected by default when the jansi module does not have native access enabled;
    This prevents the JDK from printing warning messages in stderr.

@gnodet gnodet merged commit a8961cb into fusesource:master Oct 2, 2023
3 checks passed
@gnodet gnodet added this to the 2.5.0 milestone Oct 2, 2023
@Glavo Glavo deleted the package branch October 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants