-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GraalVM native image configuration files #21
base: master
Are you sure you want to change the base?
Conversation
For reference, see * https://github.com/oracle/graal/blob/master/substratevm/JNI.md * https://github.com/oracle/graal/blob/master/substratevm/RESOURCES.md The resource configuration allows the windows64/jansi.dll file to be included in the native image.
The I’ll update the PR. |
On second thought, the current |
why support only Windows by default, and not other OS? |
on jni-config.json, is there a way to check that the content matches the library? to avoid issues in the future if the library is updated |
@hboutemy Thanks for getting back!
Yes, that sounds reasonable.
Interesting! What is the use case for Jansi on Linux and Mac? I thought on those OS's ANSI colors are supported out of the box.
Good point. Yes, every time the library is updated, the
Then, ensure the file is included in the jansi JAR in the following location (any unique location under
|
Jansi provides access to several low level functions that are useful when a java application needs to access the console. Those are the ones in the
I'd like to release a new version of Jansi. Can we leave that aside or do we need to consider fixing the problems before ? |
@gnodet Thanks for getting back!
A new release, great! Sounds like an opportunity to fix the problem! :-) jni-configThis is straightforward. You can either include the file from this PR, or, you can regenerate the Include the
resource-configGiven your feedback, the simplest idea is to create a
Include this
What this doesThe above two steps will allow applications to use the jansi functionality in GraalVM native images. Including all native Jansi libs in the GraalVM native image is a bit overkill (ideally a MacOS native image would only include |
This PR adds GraalVM native image configuration files. These configuration files allow applications that use JANSI to be compiled to native images.
This PR partly addresses fusesource/jansi#162 ; I raised another PR in the hawtjni project to address the
Library
issue.For reference, see
The resource configuration allows the windows64/jansi.dll file to be included in the native image.
The intention is that these files end up in the
jansi-$VERSION.jar
file in the following locations: