Add Fee to OriginalTokenBridge #6
Conversation
| const withdrawalFee = (amount * BigInt(withdrawalFeeBps)) / BigInt(10000) / LDtoSD | ||
|
|
||
| await originalTokenBridge.connect(owner).withdrawFee(originalToken.target, owner.address, withdrawalFee) | ||
| expect(await originalToken.balanceOf(owner.address)).to.be.eq(withdrawalFee) |
There was a problem hiding this comment.
Can you check the following:
when fee is 1%, while bridging X user receives 99%, the fees are 1%.
I see you only checked the fee part
There was a problem hiding this comment.
@leonprou I have updated the test which checks the total value locked for a token which is essentially the actual amount of token sent in the LZ message to be minted on the dest chain
| expect(await originalToken.balanceOf(owner.address)).to.be.eq(withdrawalFee) | ||
| }) | ||
|
|
||
| it("bridges WETH and withdraws fees", async () => { |
There was a problem hiding this comment.
that's actually bridging native, no?
There was a problem hiding this comment.
yes, this is what we will be using for FUSE token
| @@ -107,13 +119,20 @@ contract OriginalTokenBridgeUpgradable is TokenBridgeBaseUpgradable { | |||
| require(to != address(0), "OriginalTokenBridge: invalid to"); | |||
| _checkAdapterParams(remoteChainId, PT_MINT, adapterParams); | |||
|
|
|||
| uint withdrawalAmountLD = amountLD; | |||
| if (withdrawalFeeBps > 0) { | |||
| uint withdrawalFee = (amountLD * withdrawalFeeBps) / TOTAL_BPS; | |||
There was a problem hiding this comment.
Please check this flow with max and min values for uint
There was a problem hiding this comment.
@leonprou why is that needed?
There was a problem hiding this comment.
The user sends a really big amount of tokens, when it gets multiplied by withdrawalFeeBps an integer overflow might happen.
No description provided.