Introduce DiskCachePolicy in HttpImageSource #1356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpImageSource
since version 1.12 has support for disk caching to store downloaded images on the local disk usingDiskCache
property, so next time when we loaded image again with the same URL it will pick up from local disk instead of making request to the network.But the current implementation of disk caching does not obey Http cache-control header sent by the server. So it always uses a local version even if the server mark image as stale and has to load again from the network.
We introduce
DiskCachePolicy
to give options on how DiskCache should behavior. There are two options:Note:
This PR requires Uno PR: fuse-open/uno#321
This PR contains: