Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Image bounds in NativeViewHost on iOS #1341

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

ichan-mb
Copy link
Member

This is a fix when Image Component placed inside a Panel with no size or alignment specified in NativeViewHost environment,

the Image component size will not respect the size of its container, but instead, it will draw in accordance with the size of the image itself and the Image component will overlap the size of its container when the image size is larger than the container itself

This PR contains:

  • Changelog
  • Documentation
  • Tests

Copy link
Member

@mortend mortend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@mortend mortend merged commit bc1f200 into fuse-open:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants