Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: fix compile-time warnings #1335

Merged
merged 3 commits into from
Dec 23, 2019
Merged

Conversation

mortend
Copy link
Member

@mortend mortend commented Dec 21, 2019

This fixes some compile-time warnings when building for iOS.

/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:123:4: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:127:34: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:129:36: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:129:81: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:131:4: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:136:4: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:137:7: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:140:34: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:142:36: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:142:81: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:144:4: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:146:7: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:147:5: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:152:4: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:153:7: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:154:7: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:155:5: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:176:24: warning: initializing 'FusePinAnnotation *__strong' with an expression of incompatible type 'id<MKAnnotation> _Nullable'
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/MapViewDelegate.m:322:23: warning: initializing 'FusePinAnnotation *__strong' with an expression of incompatible type '__strong id<MKAnnotation> _Nonnull'
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/KeyboardContext.mm:30:100: warning: implicit conversion loses integer precision: 'UIViewAnimationCurve' to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
/Users/morten/fuselibs/Tests/ManualTests/ManualTestingApp/build/iOS/Debug/src/iOS/ImagePicker.m:23:37: warning: block implicitly retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]

@mortend mortend merged commit f0bdfff into fuse-open:master Dec 23, 2019
@mortend mortend deleted the ios-warnings branch December 23, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant