Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse.Models: allow unsetting Model #1306

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Conversation

mortend
Copy link
Member

@mortend mortend commented Sep 17, 2019

This will avoid getting the following error when setting the Model attribute
to empty string (can't pass null from UX).

Error: : Uncaught require(): module not found:
In: Fuse.Scripting.DiagnosticSubject
Fuse: (model-script):4

This PR contains:

  • Changelog
  • Documentation
  • Tests

This will avoid getting the following error when setting the Model attribute
to empty string (can't pass `null` from UX).

    Error: : Uncaught require(): module not found:
	In: Fuse.Scripting.DiagnosticSubject
	Fuse: (model-script):4
Copy link
Contributor

@kusma kusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look OK to me...

@kusma kusma merged commit 6d22923 into fuse-open:master Sep 17, 2019
@mortend mortend deleted the empty-model branch September 17, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants