fix undefined check, add null test for browser

fullstack-build · Aug 22, 2023 · d510305 · d510305
1 parent 6ab687e
commit d510305
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/runtime/browser/util.inspect.polyfil.ts b/src/runtime/browser/util.inspect.polyfil.ts
@@ -63,7 +63,7 @@ function isBoolean(arg: unknown) {
 }
 
 function isUndefined(arg: unknown) {
-  return arg == null;
+  return arg === undefined;
 }
 
 function stylizeNoColor(str: string) {

diff --git a/tests/Browser/1_json.test.ts b/tests/Browser/1_json.test.ts
@@ -75,4 +75,14 @@ describe("Browser: JSON: Log level", () => {
 
     expect(consoleOutput).toContain("Foo bar");
   });
+
+  it("pretty nullish", async () => {
+    await page.evaluate(() => {
+      // @ts-ignore
+      const logger = new tslog.Logger({ type: "pretty", stylePrettyLogs: false });
+      logger.info({ foo: null, bar: undefined });
+    });
+    expect(consoleOutput).toContain("null");
+    expect(consoleOutput).toContain("undefined");
+  });
 });