Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add zstd support #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat: Add zstd support #31

wants to merge 3 commits into from

Conversation

kockan
Copy link

@kockan kockan commented Aug 16, 2023

An attempt at adding zstd support in a similar fashion to how gzip is handled.

Once (if) fulcrumgenomics/fgoxide#9 is approved, would be used for: #20

nh13
nh13 requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question around what belongs here and in fgoxide (already)

src/lib/mod.rs Outdated Show resolved Hide resolved
src/lib/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh13 nh13 nh13 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kockan @nh13