Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing of static binaries #24

Merged
merged 19 commits into from
Feb 24, 2023
Merged

Fix publishing of static binaries #24

merged 19 commits into from
Feb 24, 2023

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Feb 22, 2023

Fixes: #21

See the successful publish github action: https://github.com/fulcrumgenomics/tmp-fqgrep-githubactions/actions/runs/4239758449.
See the binaries automatically generated by the publish github action: https://github.com/fulcrumgenomics/tmp-fqgrep-githubactions/releases/tag/v16

.github/workflows/publish.yml Outdated Show resolved Hide resolved
@jma1991
Copy link

jma1991 commented Feb 22, 2023

fqgrep-x86_64-apple-darwin runs with no errors on MacBook Air (M1, Ventura 13.0.1)

@bnovak32
Copy link

fqgrep-x86_64-apple-darwin runs without errors on a MacBook Air (M2, Ventura 13.2.1)

Using docker on the same computer, I can also run fqgrep-x86_64-unknown-linux-musl with no issues (docker images based on alpine and ubuntu both work).

When I try to run fqgrep-arm-unknown-linux-gnueabihf in an ubuntu container I get this error: "qemu-arm: Could not open '/lib/ld-linux-armhf.so.3': No such file or directory"

@nh13
Copy link
Member Author

nh13 commented Feb 24, 2023

@bnovak32 I think the arm release you need to use the arm32v7/ubuntu docker image (32-bit). I don't have an arm64 target (e.g. aarch64-unknown-linux-gnu). I'd be glad for a PR if folks want one.

@nh13 nh13 merged commit 806ce2e into main Feb 24, 2023
@nh13 nh13 deleted the fix/publishing branch February 24, 2023 16:50
@bnovak32
Copy link

@bnovak32 I think the arm release you need to use the arm32v7/ubuntu docker image (32-bit). I don't have an arm64 target (e.g. aarch64-unknown-linux-gnu). I'd be glad for a PR if folks want one.

I think it would be great to have an arm64 version because that's what you get when running docker on an m1/m2 Mac. I try to always build amd64/arm64 multi-platform docker images to easily transfer workflows across different systems. I can just install from source, though, so it's not a big deal.

@nh13
Copy link
Member Author

nh13 commented Feb 24, 2023

@bnovak32 if you want to test out a aarch64-unknown-linux-gnu, it's a simple as creating a new repo (not forking), pushing the main branch here up there, then update the publish with the github actions (add the aarch64-unknown-linux-gnu target), then pushing a tag to kick off the publish github action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide staticly-linked binary?
3 participants