Added standard pre-commit script that runs formatting, clippy and tests. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a rust-toolchain file.
tfenne
force-pushed
the
tf_add_precommit_script
branch
2 times, most recently
from
7867d13
to
70f66b5
Compare
tfenne
force-pushed
the
tf_add_precommit_script
branch
from
70f66b5
to
d80dc14
Compare
|
@nh13 and @samfulcrum - shall I merge this? |
nh13
requested changes
Oct 31, 2022
|
I think if it's easy it would be great to use the same thing in github actions (perhaps with --check to rust fmt; the script as is reformats). But I don't quite know how that interacts with how the actions are setup now. |
sam-white04
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Good idea, thank you for adding this.
Note - I ran precommit.sh, everything passed, and when I pushed I still received a clippy error in matcher.rs. Weird since there were no changes made to that file. I also ran 'cargo fmt' manually in addition to precommit.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.