feat(progress-logger): added a progress logger #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nh13
requested changes
Aug 6, 2022
| .name("fqgrep-progress") | ||
| .noun("reads") | ||
| .verb("Searched") | ||
| .unit(50_000_000) |
There was a problem hiding this comment.
Shall we separate with comma's (there's a crate for that)?
There was a problem hiding this comment.
Sure! I'll put it behind a feature flag I think to keep proglog low dependency by default, but agree tidier numbers would be nice.
There was a problem hiding this comment.
I am not going to hold this PR up, thank-you @sstadick !
nh13
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple progress logger into the hot loop to "greps" the reads to track how many reads have been searched so far. With it's existing configuration it emits ~ 1 log message every 30 seconds.
Example logging output of a full run:
With some crude CLI benchmarking on both
fqgrepand other projectsproglogdoes not slow down hot loops to any appreciable degree as long asunitsize is set high enough.