Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleCounter iterators are in insertion order #73

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Nov 1, 2021

No description provided.

@nh13 nh13 requested a review from tfenne November 1, 2021 21:11
@nh13
Copy link
Member Author

nh13 commented Nov 1, 2021

@tfenne Happy to add a unit test if you agree.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #73 (b862308) into master (b851fd3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          27       27           
  Lines         857      857           
  Branches       57       57           
=======================================
  Hits          799      799           
  Misses         58       58           
Flag Coverage Δ
unittests 93.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/fulcrumgenomics/commons/util/SimpleCounter.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b851fd3...b862308. Read the comment docs.

@tfenne
Copy link
Member

tfenne commented Nov 2, 2021

@nh13 I think this is nice (at least gives some deterministic order) but just would want to make sure it's not massively slower to use a LinkedHashMap - hopefully once the value is inserted the overhead is zero?

Also, I can haz a def keys: Iterator[T]?

@tfenne tfenne merged commit ffd57b8 into master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants