-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Io.readBytesFromResources() to read binary data. #33
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 92.36% 92.39% +0.02%
==========================================
Files 17 17
Lines 642 644 +2
Branches 86 86
==========================================
+ Hits 593 595 +2
Misses 49 49
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One unneeded import, otherwise LGTM.
Source.fromInputStream(stream).withClose(() => stream.safelyClose()).getLines | ||
} | ||
val stream = new BufferedInputStream(streamFromResource(name), bufferSize) | ||
Source.fromInputStream(stream).withClose(() => stream.safelyClose()).getLines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this too!
@@ -27,6 +27,8 @@ import java.io._ | |||
import java.nio.file.{Files, Path} | |||
|
|||
import com.fulcrumgenomics.commons.CommonsDef._ | |||
|
|||
import scala.collection.mutable.ArrayBuffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, thanks!
No description provided.