Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Io.readBytesFromResources() to read binary data. #33

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

tfenne
Copy link
Member

@tfenne tfenne commented Jul 30, 2018

No description provided.

@tfenne tfenne requested a review from nh13 July 30, 2018 19:57
@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #33 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   92.36%   92.39%   +0.02%     
==========================================
  Files          17       17              
  Lines         642      644       +2     
  Branches       86       86              
==========================================
+ Hits          593      595       +2     
  Misses         49       49
Impacted Files Coverage Δ
...main/scala/com/fulcrumgenomics/commons/io/Io.scala 88.7% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e9aa...694d8b3. Read the comment docs.

Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unneeded import, otherwise LGTM.

Source.fromInputStream(stream).withClose(() => stream.safelyClose()).getLines
}
val stream = new BufferedInputStream(streamFromResource(name), bufferSize)
Source.fromInputStream(stream).withClose(() => stream.safelyClose()).getLines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this too!

@@ -27,6 +27,8 @@ import java.io._
import java.nio.file.{Files, Path}

import com.fulcrumgenomics.commons.CommonsDef._

import scala.collection.mutable.ArrayBuffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, thanks!

@nh13 nh13 assigned tfenne and unassigned nh13 Aug 6, 2018
@tfenne tfenne merged commit 98c38b0 into master Aug 6, 2018
@tfenne tfenne deleted the tf_io_read_bytes_from_res branch August 6, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants