df/load! properly handles components with a union query #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df/load! was altering component queries and making them invalid when they were a union query at the top level component. More info can be found in issue#556. This commit wraps the component query in a temporary top level root query before eliding attributes provided by the without option, which is what was causing the problem.
|
Thanks |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
df/load! was altering component queries and making them invalid when
they were a union query at the top level component. More info can be
found in #556.
This commit wraps the component query in a temporary top level root
query before eliding attributes provided by the without option, which is
what was causing the problem.