Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scrollable module to prepare for upcoming features #86

Merged
merged 13 commits into from
Apr 13, 2024
Merged

Refactor scrollable module to prepare for upcoming features #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
83b2c04
Make SheetContentScrollPosition's delegate property final
fujidaiti Apr 9, 2024
2d8183e
Make SheetContentScrollController private
fujidaiti Apr 9, 2024
24bf3fd
Improvements in SheetContentScrollPositionDelegate
fujidaiti Apr 9, 2024
38aad19
Remove outdated TODO
fujidaiti Apr 9, 2024
c09fada
Rename delegation methods
fujidaiti Apr 10, 2024
dde4e10
Refactor activities for scrollable sheet
fujidaiti Apr 10, 2024
e76f509
Format
fujidaiti Apr 10, 2024
11b22df
Mark PrimarySheetContentScrollController as @internal
fujidaiti Apr 11, 2024
6a15a40
Rename SheetContentScrollControllerScope to SheetScrollable
fujidaiti Apr 11, 2024
aa46af5
Remove ScrollableSheetPhysicsMixin
fujidaiti Apr 11, 2024
8ab484d
Move SheetContentScrollController to scrollable_sheet_extent.dart
fujidaiti Apr 11, 2024
219d01d
Rename SheetContentScrollPosition to DelegatableScrollPosition
fujidaiti Apr 11, 2024
3b28592
Remove unused utility
fujidaiti Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package/lib/smooth_sheets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,7 @@ export 'src/modal/modal_sheet.dart';
export 'src/navigation/navigation_route.dart';
export 'src/navigation/navigation_routes.dart';
export 'src/navigation/navigation_sheet.dart';
export 'src/scrollable/scrollable_sheet.dart';
export 'src/scrollable/scrollable_sheet_extent.dart';
export 'src/scrollable/scrollable_sheet.dart'
hide PrimarySheetContentScrollController;
export 'src/scrollable/scrollable_sheet_extent.dart'
hide SheetContentScrollController;
3 changes: 0 additions & 3 deletions package/lib/src/internal/into.dart
View file
Open in desktop

This file was deleted.

209 changes: 0 additions & 209 deletions package/lib/src/scrollable/content_scroll_position.dart
View file
Open in desktop

This file was deleted.

Loading
Loading