Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to conditionally interrupt a modal sheet route popping #18

Closed
fujidaiti opened this issue Jan 29, 2024 · 0 comments · Fixed by #39 or #41
Closed

Provide a way to conditionally interrupt a modal sheet route popping #18

fujidaiti opened this issue Jan 29, 2024 · 0 comments · Fixed by #39 or #41
Assignees
@fujidaiti
Labels
feature request New feature or request
Milestone
v0.3.0

Comments

@fujidaiti
Copy link
Owner

fujidaiti commented Jan 29, 2024 •
edited
Loading

Something like WillPopScope widget. One possible usecase is to display a dialog to confirm dismissing a modal sheet when it is dragged down.
@fujidaiti fujidaiti added the feature request New feature or request label Jan 29, 2024
@fujidaiti fujidaiti added this to the v0.3.0 milestone Jan 30, 2024
@fujidaiti fujidaiti self-assigned this Feb 2, 2024
This was referenced Feb 23, 2024
Closed
Merged
fujidaiti added a commit that referenced this issue Feb 23, 2024
@fujidaiti
Add conditional modal sheet popping feature (#39)
65331da 
Closes #18.

# New Feature
- Add `SheetDismissible`, which enables the enclosed sheet to be
dismissed by a drag-down gesture. It accepts an `onDismiss` callback,
which will be invoked when the user tries to dismiss the sheet by
dragging it down, providing an opportunity to determine if the sheet
should be dismissed.

# Changes
- Add tutorial code for `SheetDismissible`.
- Update the Safari and the AI playlist generator example to use
`SheetDismissible` to show a confirmation dialog to discard changes.

# Breaking Changes
- Remove `ModalSheetRouteMixin.enablePullToDismiss`.
@fujidaiti fujidaiti linked a pull request Feb 23, 2024 that will close this issue
Add conditional modal sheet popping feature #39
Merged
@fujidaiti fujidaiti mentioned this issue Feb 24, 2024
Merged
fujidaiti added a commit that referenced this issue Feb 24, 2024
@fujidaiti
Add conditional modal sheet popping feature (#41)
90c8f10 
Closes #18.

# New Feature
- Add `SheetDismissible`, which enables the enclosed sheet to be
dismissed by a drag-down gesture. It accepts an `onDismiss` callback,
which will be invoked when the user tries to dismiss the sheet by
dragging it down, providing an opportunity to determine if the sheet
should be dismissed.

# Changes
- Add tutorial code for `SheetDismissible`.
- Update the Safari and the AI playlist generator example to use
`SheetDismissible` to show a confirmation dialog to discard changes.

# Breaking Changes
- Remove `ModalSheetRouteMixin.enablePullToDismiss`.
@kmorl kmorl mentioned this issue May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fujidaiti fujidaiti

Labels
feature request New feature or request
Projects
None yet
Milestone
v0.3.0
1 participant
@fujidaiti