Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display individual tracing flows in Tui #777

Closed
Tracked by #776
fujiapple852 opened this issue Nov 11, 2023 · 1 comment · Fixed by #780
Closed
Tracked by #776

Display individual tracing flows in Tui #777

fujiapple852 opened this issue Nov 11, 2023 · 1 comment · Fixed by #780
Labels
enhancement New feature or request tui
Milestone
0.9.0

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Nov 11, 2023 •
edited
Loading

Trippy records data for individual flows as well as for the default flow, which is the union of all flows. Presently the Tui only displays the default flow. It is desirable to be able to select to display individual flows from within the Tui.

It is not clear what a god UX is for this as there may be many flows for a given trace (i.e. hundreds is not out of the question).

Given:

  • flows are only really use for UDP and TCP tracing
  • Trippy only support tracing to multiple targets for ICMP mode

Then it follows that flows will only be allowed for tracing to a single target, and as such the "tabs" could be used to allow selection of a flow. However the Tab control does not scroll.
@fujiapple852 fujiapple852 mentioned this issue Nov 11, 2023
Closed
5 tasks
@fujiapple852 fujiapple852 self-assigned this Nov 11, 2023
@fujiapple852 fujiapple852 added the enhancement New feature or request label Nov 11, 2023
@fujiapple852 fujiapple852 added this to the 0.9.0 milestone Nov 11, 2023
fujiapple852 added a commit that referenced this issue Nov 11, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777) - WIP
3f780f7
@fujiapple852 fujiapple852 mentioned this issue Nov 11, 2023
Merged
fujiapple852 added a commit that referenced this issue Nov 12, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777) - WIP
6fc06eb
fujiapple852 added a commit that referenced this issue Nov 12, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777) - WIP
75b08eb
fujiapple852 added a commit that referenced this issue Nov 13, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777) - WIP
10eb566
fujiapple852 added a commit that referenced this issue Nov 13, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777) - WIP
67b0915
fujiapple852 added a commit that referenced this issue Nov 14, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777) - WIP
2d3993e
@fujiapple852
Copy link
Owner Author

The current WIP UX is as shown below:

Kapture 2023-11-15 at 21 28 24

fujiapple852 added a commit that referenced this issue Nov 25, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777) - WIP
8424854
fujiapple852 added a commit that referenced this issue Nov 25, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777)
1590f47
fujiapple852 added a commit that referenced this issue Nov 25, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777)
fc0358b
fujiapple852 added a commit that referenced this issue Nov 25, 2023
@fujiapple852
feat(tui): display individual tracing flows in Tui (#777)
6e92b2b
@fujiapple852 fujiapple852 removed their assignment Nov 25, 2023
fujiapple852 added a commit that referenced this issue Nov 25, 2023
@fujiapple852
doc: added #777 to CHANGELOG.md
482caff
fujiapple852 added a commit that referenced this issue Nov 25, 2023
@fujiapple852
doc: added #777 to CHANGELOG.md
9ef409e
fujiapple852 added a commit that referenced this issue Nov 25, 2023
@fujiapple852
doc: added #777 to CHANGELOG.md
53ee516
@chenrui333 chenrui333 mentioned this issue Nov 30, 2023
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Dec 1, 2023
@0323pin
net/trippy: update to 0.9.0
71ffae6 
[0.9.0] - 2023-11-30

Added

- Added support for tracing flows
  ([#776](fujiapple852/trippy#776))
- Added support for `icmp` extensions
  ([#33](fujiapple852/trippy#33))
- Added support for `MPLS` label stack class `icmp` extension
  objects ([#753](fujiapple852/trippy#753))
- Added support for [paris]
  (https://github.com/libparistraceroute/libparistraceroute) ECMP routing
  for `IPv6/udp` ([#749](fujiapple852/trippy#749))
- Added `--unprivileged` (`-u`) flag to allow tracing without elevated
  privileges (macOS
  only) ([#101](fujiapple852/trippy#101))
- Added `--tui-privacy-max-ttl` flag to hide host and IP details for low ttl
  hops ([#766](fujiapple852/trippy#766))
- Added `toggle-privacy` (default: `p`) key binding to show or hide private
  hops ([#823](fujiapple852/trippy#823))
- Added `toggle-flows` (default: `f`) key binding to show or hide tracing
  flows ([#777](fujiapple852/trippy#777))
- Added `--dns-resolve-all` (`-y`) flag to allow tracing to all IPs resolved
  from DNS lookup
  entry ([#743](fujiapple852/trippy#743))
- Added `dot` report mode (`-m dot`) to output hop graph in Graphviz `DOT`
  format ([#582](fujiapple852/trippy#582))
- Added `flows` report mode (`-m flows`) to output a list of all unique tracing
  flows ([#770](fujiapple852/trippy#770))
- Added `--icmp-extensions` (`-e`) flag for parsing `IPv4`/`IPv6` `icmp`
  extensions ([#751](fujiapple852/trippy#751))
- Added `--tui-icmp-extension-mode` flag to control how `icmp` extensions are
  rendered ([#752](fujiapple852/trippy#752))
- Added `--print-config-template` flag to output a template config
  file ([#792](fujiapple852/trippy#792))
- Added `--icmp` flag as a shortcut for `--protocol icmp`
  ([#649](fujiapple852/trippy#649))
- Added `toggle-help-alt` (default: `?`) key binding to show or hide
  help ([#694](fujiapple852/trippy#694))
- Added panic handing to Tui
  ([#784](fujiapple852/trippy#784))
- Added official Windows `scoop` package
  ([#462](fujiapple852/trippy#462))
- Added official Windows `winget` package
  ([#460](fujiapple852/trippy#460))
- Release `musl` Debian `deb` binary asset
  ([#568](fujiapple852/trippy#568))
- Release `armv7` Linux binary assets
  ([#712](fujiapple852/trippy#712))
- Release `aarch64-apple-darwin` (aka macOS Apple Silicon) binary
  assets ([#801](fujiapple852/trippy#801))
- Added additional Rust Tier 1 and Tier 2 binary assets
  ([#811](fujiapple852/trippy#811))

Changed

- [BREAKING CHANGE] `icmp` extension object data added to `json` and `stream`
  reports ([#806](fujiapple852/trippy#806))
- [BREAKING CHANGE] IPs field added to `csv` and all tabular
  reports ([#597](fujiapple852/trippy#597))
- [BREAKING CHANGE] Command line flags `--dns-lookup-as-info` and
  `--tui-preserve-screen` no longer require a boolean
  argument ([#708](fujiapple852/trippy#708))
- [BREAKING CHANGE] Default key binding for `ToggleFreeze` changed from `f`
  to `ctrl+f` ([#785](fujiapple852/trippy#785))
- Always render AS lines in hop details mode
  ([#825](fujiapple852/trippy#825))
- Expose DNS resolver module as part of `trippy` library
  ([#754](fujiapple852/trippy#754))
- Replaced unmaintained `tui-rs` crate with `ratatui` crate
  ([#569](fujiapple852/trippy#569))

Fixed

- Reverse DNS lookup not working in reports
  ([#509](fujiapple852/trippy#509))
- Crash on NetBSD during window resizing
  ([#276](fujiapple852/trippy#276))
- Protocol mismatch causes tracer panic
  ([#745](fujiapple852/trippy#745))
- Incorrect row height in Tui hop detail navigation view for hops with no
  responses ([#765](fujiapple852/trippy#765))
- Unnecessary socket creation in certain tracing modes
  ([#647](fujiapple852/trippy#647))
- Incorrect byte order in `IPv4` packet length calculation
  ([#686](fujiapple852/trippy#686))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tui
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Display individual tracing flows in Tui (#777) fujiapple852/trippy
1 participant
@fujiapple852