Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] PRINT ROWS <n> -> PRINT <n> ROWS|ROW #154

Closed
goodwanghan opened this issue Jan 24, 2021 · 1 comment · Fixed by #158
Closed

[FEATURE] PRINT ROWS <n> -> PRINT <n> ROWS|ROW #154

goodwanghan opened this issue Jan 24, 2021 · 1 comment · Fixed by #158
Assignees
@nils-braun
Labels
behavior change Fugue SQL
Milestone
0.5.1

Comments

@goodwanghan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
NA

Describe the solution you'd like
The print statement in Fugue SQL needs a bit change to be consistent with TAKE statement
Currently, the syntax is

PRINT ROWS <n>

But we want to change to

PRINT <n> ROWS|ROW

to be consistent with TAKE

Describe alternatives you've considered
NA

Additional context
NA
@goodwanghan
Copy link
Collaborator Author

after you make the change in the antlr file and rebuild the sql
you should see some sql tests failed

nils-braun added a commit that referenced this issue Jan 26, 2021
@nils-braun
#154: print rows n -> print n rows
55a30b1
@nils-braun nils-braun mentioned this issue Jan 26, 2021
Merged
@goodwanghan goodwanghan added this to the 0.5.1 milestone Jan 26, 2021
nils-braun added a commit that referenced this issue Jan 27, 2021
@nils-braun
print rows n -> print n rows (#158)
37f3128 
* #154: print rows n -> print n rows

* Fixed the SQL tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nils-braun nils-braun

Labels
behavior change Fugue SQL
Projects
None yet
Milestone
0.5.1
Development

Successfully merging a pull request may close this issue.

print rows n -> print n rows fugue-project/fugue
2 participants
@nils-braun @goodwanghan