Redirect stdio #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
+ Coverage 76.04% 77.87% +1.82%
==========================================
Files 2 2
Lines 167 235 +68
==========================================
+ Hits 127 183 +56
- Misses 40 52 +12
Continue to review full report at Codecov.
|
fabianfreyer
commented
Nov 17, 2017
There was a problem hiding this comment.
After fubarnetes/fubarnetes#1 is solved, we should really use some other form of IPC rather than native mpsc.
src/process.rs
Outdated
|
|
||
| // Handle stdio | ||
| if let Some(ref mut stdout) = p.stdout_reader { | ||
| for line in stdout.lines() { | ||
| info!("{:?}", line) | ||
| p.stdout_sender |
There was a problem hiding this comment.
After fubarnetes/fubarnetes#1 is solved, this should ideally be some PUB/SUB or similar message queue.
src/process.rs
Outdated
| } | ||
| } | ||
|
|
||
| if let Some(ref mut stdin) = p.stdin_writer { | ||
| if let Ok(input) = p.stdin_receiver.try_recv() { | ||
| info!("received: {}", input); | ||
| stdin.write_all(input.as_bytes()) |
There was a problem hiding this comment.
And this probably a PULL or equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.