tests: allow test kernels to print to serial #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfreyer
commented
Feb 22, 2018
tests/data/multiboot/Makefile
Outdated
| @@ -27,7 +28,7 @@ modules.elf: start.o modules.o libc.o | |||
| $(LD) $(LDFLAGS) -o $@ $> $(LIBGCC) | |||
|
|
|||
| .c.o: | |||
| $(CC) $(CCFLAGS) -c -o $@ $< | |||
| $(CC) -DOUTPUT=COM1 $(CCFLAGS) -c -o $@ $< | |||
There was a problem hiding this comment.
COM1 should be ${OUTPUT} here
fabianfreyer
force-pushed
the
tests/kernel-output-serial
branch
from
06cdb6d to
bcea931
Compare
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
======================================
Coverage 73.9% 73.9%
======================================
Files 4 4
Lines 617 617
======================================
Hits 456 456
Misses 161 161Continue to review full report at Codecov.
|
fabianfreyer
force-pushed
the
tests/kernel-output-serial
branch
from
bcea931 to
89d5320
Compare
fabianfreyer
force-pushed
the
tests/kernel-output-serial
branch
from
89d5320 to
a34fe59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bhyve doesn't seem to support the debugcon (
outb 0xe9) port, so instead useCOM1.