-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn global support #2
Comments
@stevenjlho I'm happy for you to create a PR. I don't use Yarn an awful lot, but it has been introduced in this role to run from a global location. If you understand how we can get it to run globally better I am happy to get the changes through if tests pass :) I'd like to add a build system to build from source in the future, but I've quite a lot going in the ansible realm at the moment, I've almost bit off too much to chew. Load it up with issues you find useful and any details, and I'll certainly get around to them :) |
@stevenjlho Could you be more implicit about this functionality if you do not intend to complete it? If the intend is to manage yarn global packages as documented here, let me know. If you're intending to do this work, please let me know - I'm not particularly fond of stagnant issues nor am I one to dismiss a feature request without very good reasons and in this case there are none. |
Yes, i want to add variable
This is inspired by ansible-role-nodejs |
@stevenjlho Yeah my nodejs role works in a very similar way. With the documentation in the link in my previous post, I'll add some yarn packages to install globally and make it configurable and I'll do some checks and balances - I'll aim for a release of this 2 days as I've got a lot of ongoings on my brand new golang role. |
OK, i am waiting your next release. |
This is a draft of the work I'll begin tonight - if you see something out of wack let me know.
|
Signed-off-by: Karl Hepworth <[email protected]>
So this is now done, I'll give you a few days to test it out to provide any feedback or improvements. I assume you know how to use this role from a git clone, let me know if you don't - but all you need to do is include the role from branch I'll give you a bit of warning before release, but I want you to have the chance to provide feedback for improving this. |
I found a permission problem. When variable |
Thanks, I'll resubmit shortly. I'll make a comparison between what happens as root and other, but as the binary is installed through the native system could you please tell me the importance of running as another user and not root? The following tasks have been added, all seems well here.
|
…nted in #2 Signed-off-by: Karl Hepworth <[email protected]>
So Ubuntu 12.04 is still failing, but everything else is in check. |
It's working. But i think this solution is a bit tricky. Maybe we can change bin folder according to these issue. |
So I've been working with it a while, I've finally got something working better.
So, I'll get in fixed, and make that path configurable. Stay tuned. |
So, the next round of changes for branch issue-2 is ready for assessment. Let me know. |
I feel happier with your help.And please let me know what thing you do in next version. |
@stevenjlho the only thing I've (just) planned for either the next or the following release would be to utilize the self-update command more. Though yarn isn't exactly something I use everyday I fully intend on making all of my Ansible roles as freaking awesome as possible - so I basically don't turn down feature requests and I take bugs rather personally. If you think of anything that can help you work or make this better, please let me know! I take it from your response you're happy with the end result? I'll move onto the other task and look at a release hopefully tomorrow :) |
Pull request has been merged into master and branch issue-2 has been deleted. A release will happen very soon! |
Version 1.1 is released and available via Ansible Galaxy. |
I think this feature is helpful. Maybe I can implement it.
The text was updated successfully, but these errors were encountered: