Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Backlog/fix houdini version expression #583

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

dennisweil
Copy link
Contributor

Resolves :

  • CLICKUP-
  • FT-
  • SENTRY-
  • ZENDESK-
  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains update to the release notes.
  • The PR contains update to the documentation.

This PR has been tested on :

  • [x ] Windows.
  • MacOs.
  • [x ] Linux.

Overview

Purpose:

Scope:

Implementation Details

Approach:

Reasoning:

Changes:

Trade-offs:

Testing

Tests Added:

Manual Testing:

Testing Environment:

Notes for Reviewers

Focus Areas:

Dependencies:

Known Issues:

@dennisweil dennisweil requested a review from a team as a code owner October 16, 2024 18:57
@dennisweil dennisweil changed the title Fix: Backlog/fix houdini version expression fix: Backlog/fix houdini version expression Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator

@lluisFtrack lluisFtrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just remember to put the fix in the top of the release notes

@@ -6,6 +6,7 @@
* [changed] Init; Use create_api_session utility to create the api session.
* [changed] Host, Client instance; Pass run_in_main_thread argument.
* [fix] Init; Fix on_run_tool_callback options argument.
* [fix] Adjust version expression so Houdini Launchers can be created properly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this line as the first one

Copy link
Collaborator

@lluisFtrack lluisFtrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisweil dennisweil merged commit 7bde77a into main Oct 21, 2024
7 checks passed
@dennisweil dennisweil deleted the backlog/fix-houdini-version-expression branch October 21, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants