-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Backlog/fix houdini version expression #583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just remember to put the fix in the top of the release notes
@@ -6,6 +6,7 @@ | |||
* [changed] Init; Use create_api_session utility to create the api session. | |||
* [changed] Host, Client instance; Pass run_in_main_thread argument. | |||
* [fix] Init; Fix on_run_tool_callback options argument. | |||
* [fix] Adjust version expression so Houdini Launchers can be created properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this line as the first one
…backlog/fix-houdini-version-expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves :
This PR has been tested on :
Overview
Purpose:
Scope:
Implementation Details
Approach:
Reasoning:
Changes:
Trade-offs:
Testing
Tests Added:
Manual Testing:
Testing Environment:
Notes for Reviewers
Focus Areas:
Dependencies:
Known Issues: