Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backlog/remove js extensions support #568

Open
wants to merge 125 commits into
base: main
Choose a base branch
from

Conversation

lluisFtrack
Copy link
Collaborator

Resolves :

  • I have added automatic tests where applicable.
  • The PR contains a description of what has been changed.
  • The description contains manual test instructions.
  • The PR contains update to the release notes.
  • The PR contains update to the documentation.

This PR has been tested on :

  • Windows.
  • MacOs.
  • Linux.

Overview

Purpose: Remove the js extensions to not introduce new concepts in the framework.

Scope: framework-core, ftrack-utils and framework-harmony project.

Implementation Details

Approach: Rolled back all the changes in core and utils and moved harmony js files to resources folder to match Photoshop and Premier.

Reasoning: Introducing JS extensions could make the final user confused on its application.

Changes:

Trade-offs:

Testing

Tests Added:

Manual Testing: Build the integration. (Make sure connect is build with the same core and utils)

Testing Environment:

Notes for Reviewers

Focus Areas:

Dependencies:

Known Issues:

@lluisFtrack lluisFtrack requested a review from a team as a code owner August 8, 2024 15:10
Copy link

github-actions bot commented Aug 8, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  libs/framework-core/source/ftrack_framework_core/registry
  __init__.py
  libs/utils/source/ftrack_utils/extensions
  overrides.py 28
  registry.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant