Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numeric types #497

Closed
wants to merge 5 commits into from
Closed

Add numeric types #497

wants to merge 5 commits into from

Conversation

sh0hei
Copy link
Contributor

@sh0hei sh0hei commented May 1, 2018

  • Byte

    • PosByte
    • NonNegByte
    • NegByte
    • NonPosByte

  • Short

    • PosShort
    • NonNegShort
    • NegShort
    • NonPosShort

@fthomas
Copy link
Owner

fthomas commented May 15, 2018

@sh0hei MiMa reported that this change is not binary compatible. Moving the forwarders in NumericTypes to a new NumericTypesBinCompat1 should make this binary compatible. Something similar was done in 2fc946f.

Could also please only test the from function on each type? I don't think it is necessary to test unsafeFrom or unapply on each type since these are implemented in terms of from and we've already checked elsewhere that unsafeFrom and unapply are consistent with from.

@kusamakura kusamakura mentioned this pull request May 18, 2018
Merged
@sh0hei sh0hei force-pushed the feature/add-numeric-types branch from b984ebc to c62c614 Compare June 15, 2018 10:43
@sh0hei sh0hei force-pushed the feature/add-numeric-types branch from ce752c1 to c5a9cb4 Compare June 15, 2018 11:56
@fthomas
Copy link
Owner

fthomas commented Oct 26, 2018

I've just noted that these types were added in #567. I'm sorry for the duplicated work.

@fthomas fthomas closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh0hei @fthomas